dramaticlly commented on code in PR #14287:
URL: https://github.com/apache/iceberg/pull/14287#discussion_r2437907707
##########
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##########
@@ -119,6 +119,17 @@ public interface ExpireSnapshots extends
PendingUpdate<List<Snapshot>> {
*/
ExpireSnapshots cleanExpiredFiles(boolean clean);
+ /**
+ * Skip the cleanup of orphaned data files as part of snapshot expiration
+ *
+ * @param retain true to retain orphaned data files only reachable by
expired snapshots
+ * @return this for method chaining
+ */
+ default ExpireSnapshots retainOrphanedDataFiles(boolean retain) {
Review Comment:
Thanks @amogh-jahagirdar , I think what you proposed makes sense, as today
`retainDataFiles` need to have prerequisites of `cleanExpiredFiles=true`.
But since those are public API on interface, deprecation and removal will
need to go through cycles. I can update to use CleanupMode behind the scene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
