HeartLinked commented on PR #243: URL: https://github.com/apache/iceberg-cpp/pull/243#issuecomment-3326766045
> The `NOTICE` file is better and correct. Thanks for that. > > Imho, the `LICENSE` file is not fully correct because: > > 1. The MIT/BSD license content is missing (I don't see a separate folder containing these licenses, and the license content is not inline). > 2. It's not clear to me what do you mean by "bundle". Can you please clarify ? Thanks for your review! Actually, our project is distributed as a source package that users compile themselves. We do not copy source files from `zlib`, `spdlog`, `cpr`, etc. Instead, we directly use system installed them or vendor it by building the downloaded tarball. Previously, our LICENSE file contained sentences like "3rdparty dependency spdlog is statically linked in certain binary distributions". Based on this, I had mistakenly concluded that these dependencies should always be treated as "bundled". Following our discussion, I have now removed all related third-party license content from the file, as our project is a source-only distribution where bundling is conditional. Do you think this revised version is more accurate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
