Fokko commented on code in PR #2557:
URL: https://github.com/apache/iceberg-python/pull/2557#discussion_r2401849615
##########
pyiceberg/expressions/__init__.py:
##########
@@ -43,6 +46,11 @@
from pyiceberg.types import DoubleType, FloatType, NestedField
from pyiceberg.utils.singleton import Singleton
+try:
+ from pydantic import ConfigDict
+except ImportError:
+ ConfigDict = dict
+
Review Comment:
```suggestion
```
##########
pyiceberg/expressions/__init__.py:
##########
@@ -31,6 +31,9 @@
TypeVar,
Union,
)
+from typing import Literal as TypingLiteral
+
+from pydantic import Field
Review Comment:
```suggestion
from pydantic import Field, ConfigDict
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
