aiborodin commented on code in PR #14312:
URL: https://github.com/apache/iceberg/pull/14312#discussion_r2426107404
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommittable.java:
##########
@@ -26,35 +26,35 @@
/**
* The aggregated results of a single checkpoint which should be committed.
Containing the
- * serialized {@link DeltaManifests} file - which contains the commit data,
and the jobId,
+ * serialized {@link DeltaManifests} files - which contains the commit data,
and the jobId,
* operatorId, checkpointId triplet to identify the specific commit.
*
* <p>{@link DynamicCommittableSerializer} is used to serialize {@link
DynamicCommittable} between
* the {@link DynamicWriter} and the {@link DynamicWriteResultAggregator}.
*/
class DynamicCommittable implements Serializable {
- private final WriteTarget key;
- private final byte[] manifest;
+ private final TableKey key;
+ private final byte[][] manifests;
Review Comment:
I attempted this, and it didn't work. Please, see my comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
