zhangminglei commented on a change in pull request #1659:
URL: https://github.com/apache/iceberg/pull/1659#discussion_r512535245
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -134,17 +134,26 @@ protected Catalog createCatalog(String name, Map<String,
String> properties, Con
private static Configuration mergeHiveConf(Configuration hadoopConf, String
hiveConfDir) {
Configuration newConf = new Configuration(hadoopConf);
+
+ // Approach: Parse the hive-site.xml from hive-conf-dir if possible.
Review comment:
updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
