zhjwpku commented on code in PR #257:
URL: https://github.com/apache/iceberg-cpp/pull/257#discussion_r2434396808
##########
src/iceberg/CMakeLists.txt:
##########
@@ -47,7 +47,10 @@ set(ICEBERG_SOURCES
table.cc
table_metadata.cc
table_properties.cc
+ table_requirement.cc
Review Comment:
I guess you should also add these files to meson.build.
##########
src/iceberg/util/string_util.h:
##########
@@ -44,6 +44,11 @@ class ICEBERG_EXPORT StringUtils {
[](char c) { return std::toupper(c); }); // NOLINT
return input;
}
+
+ static bool EqualsIgnoreCase(const std::string& a, const std::string& b) {
Review Comment:
nit: We have some `operator==` definitions that use `lhs`/`rhs` as the
parameters names, should we follow the same convention here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
