shangxinli commented on code in PR #14153:
URL: https://github.com/apache/iceberg/pull/14153#discussion_r2379042090
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java:
##########
@@ -266,4 +279,37 @@ public void testInvalidUpperBoundBinary() throws Exception
{
assertThat(dataFile.lowerBounds()).as("Should have a valid lower
bound").containsKey(3);
assertThat(dataFile.upperBounds()).as("Should have a null upper
bound").doesNotContainKey(3);
}
+
+ @Test
+ public void testDataWriterWithVariantShredding() throws IOException {
Review Comment:
Consider adding tests for edge cases:
1. **Null shredding function**: What happens when
`variantShreddingFunc(null)` is called?
2. **No shredding function set**: Default behavior when the method is
never called
3. **Exception handling**: If the shredding function throws an exception
during writing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
