singhpk234 commented on code in PR #13400:
URL: https://github.com/apache/iceberg/pull/13400#discussion_r2394909262
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -460,6 +468,11 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
trackFileIO(ops);
+ RESTTable restTable = getRemoteScanPlanningTable(ops, finalIdentifier,
tableClient);
+ if (restTable != null) {
+ return restTable;
+ }
Review Comment:
Metadata tables would be tricky (may be we can offload some metadata tables
like FILES ?) but for metadata tables like `all_manifests` etc requires knowing
the manifests, which in Remote Planning we expect client not to care, can't be
resolved with the same RestTable as we don't have the metadata for it.
if the expectation is the client has the credentials to read the table
(since it can read the manifests directly) would it be better to then cut off
RestTable from the loop ?
experimenting with RestTable added a test (taking a deeper look) in the
current revision `testMetadataTablesWithRemotePlanning` mostly from pure JAVA
API `MetadataTableUtils.createMetadataTableInstance()` is a public API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
