geruh commented on code in PR #14341: URL: https://github.com/apache/iceberg/pull/14341#discussion_r2437039173
########## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.ManifestFile; + +/** An action that will repair manifests. Implementations should produce a new set of manifests. */ +public interface RepairManifests extends SnapshotUpdate<RepairManifests, RepairManifests.Result> { + + /** + * Configuration method for repairing manifest entry statistics + * + * @return this for method chaining + */ + RepairManifests repairEntryStats(); + + /** + * Configuration method for removing duplicate file entries and removing files which no longer + * exist in storage Review Comment: Hey @singhpk234!! In regards to duplicates, I've seen if we have duplicates committed across snapshots it will result in duplicate rows in Spark. As for duplicates in the same operation, they are deduplicated with the DataFileSet during the operation. But in the previous PR, there are some users who can't even read their tables right now if their table has duplicate manifests accross the snapshots. For deleted files, the `FileIO` will throw an exception when it can't open a missing file but that's at th engine level. I agree that duplicates and missing files are different types of issues, but I still think they should be handled together in one action. The main goal is to restore the table to a queryable state and returning the manifests to most correct state. Most users just want to be able to query their table again that’s the priority. Once the table is readable, they can inspect it, understand what went wrong, and decide whether it’s worth doing a deeper fix. But, I'd like to hear what others think about this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
