zeroshade commented on code in PR #588:
URL: https://github.com/apache/iceberg-go/pull/588#discussion_r2406008264
##########
.github/workflows/rc.yml:
##########
Review Comment:
the `audit` step is definitely necessary and should be run.
We also don't want to remove the `verify` step because then we have no CI
for the verify_rc.sh script ensuring we don't break it.
##########
.github/workflows/rc.yml:
##########
@@ -18,12 +18,8 @@
name: RC
on:
push:
- branches:
- - '**'
- - '!dependabot/**'
tags:
- '*-rc*'
- pull_request:
Review Comment:
we were still doing this on pull requests too so that we can ensure that we
don't break the script in any PRs. otherwise the only way to test this is to
actually *do* a release rc which isn't good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
