danielcweeks commented on PR #14225: URL: https://github.com/apache/iceberg/pull/14225#issuecomment-3353549473
> Thanks @danielcweeks , looks right to me. Tested this out locally too and don't hit any no such method failures from log4j. This feels like a good thing to also get in for 1.10.1 as well. Also, doesn't look like LICENSE need to be updated but do we also need to update the NOTICE here https://github.com/apache/iceberg/blob/main/aws-bundle/NOTICE#L295 ? I think there are still a couple classes that are relocated and the notice does say "optionally" so I don't think we need an update here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
