nandorKollar commented on code in PR #14266:
URL: https://github.com/apache/iceberg/pull/14266#discussion_r2417969584
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -400,13 +400,33 @@ public static Type find(Type type, Predicate<Type>
predicate) {
}
public static boolean isPromotionAllowed(Type from, Type.PrimitiveType to) {
Review Comment:
nit: I think we should deprecate this method, and maybe highlight in the
javadoc, that it doesn't take source id reference into consideration, unlike
the other method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
