pvary commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2444547360
########## core/src/main/java/org/apache/iceberg/formats/FormatModelRegistry.java: ########## @@ -0,0 +1,234 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.data; + +import java.util.List; +import java.util.Map; +import org.apache.iceberg.ContentFile; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.FileFormat; +import org.apache.iceberg.common.DynMethods; +import org.apache.iceberg.deletes.EqualityDeleteWriter; +import org.apache.iceberg.deletes.PositionDelete; +import org.apache.iceberg.deletes.PositionDeleteWriter; +import org.apache.iceberg.encryption.EncryptedOutputFile; +import org.apache.iceberg.io.DataWriter; +import org.apache.iceberg.io.FileAppender; +import org.apache.iceberg.io.FormatModel; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.io.ReadBuilder; +import org.apache.iceberg.io.WriteBuilder; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.Pair; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * A registry that manages file-format-specific readers and writers through a unified object model + * factory interface. + * + * <p>This registry provides access to {@link ReadBuilder}s for data consumption and various writer + * builders: + * + * <ul> + * <li>{@link WriteBuilder} for basic file writing, + * <li>{@link DataWriteBuilder} for data files, + * <li>{@link EqualityDeleteWriteBuilder} for equality deletes, + * <li>{@link PositionDeleteWriteBuilder} for position deletes. + * </ul> + * + * The appropriate builder is selected based on {@link FileFormat} and object model name. + * + * <p>{@link FormatModel} objects are registered through {@link #register(FormatModel)} and used for + * creating readers and writers. Read builders are returned directly from the factory. Write + * builders may be wrapped in specialized content file writer implementations depending on the + * requested builder type. + */ +public final class FormatModelRegistry { + private static final Logger LOG = LoggerFactory.getLogger(FormatModelRegistry.class); + // The list of classes which are used for registering the reader and writer builders + private static final List<String> CLASSES_TO_REGISTER = ImmutableList.of(); + + private static final Map<Pair<FileFormat, String>, FormatModel<?>> FORMAT_MODELS = + Maps.newConcurrentMap(); + + /** + * Registers an {@link FormatModel} in this registry. + * + * <p>The {@link FormatModel} creates readers and writers for a specific combinations of file + * format (Parquet, ORC, Avro) and object model (for example: "generic", "spark", "flink", etc.). + * Registering custom factories allows integration of new data processing engines for the + * supported file formats with Iceberg's file access mechanisms. + * + * <p>Each factory must be uniquely identified by its combination of file format and object model + * name. This uniqueness constraint prevents ambiguity when selecting factories for read and write + * operations. + * + * @param formatModel the factory implementation to register + * @throws IllegalArgumentException if a factory is already registered for the combination of + * {@link FormatModel#format()} and {@link FormatModel#modelName()} + */ + @SuppressWarnings("CatchBlockLogException") + public static void register(FormatModel<?> formatModel) { + Pair<FileFormat, String> key = Pair.of(formatModel.format(), formatModel.modelName()); + if (FORMAT_MODELS.containsKey(key)) { + throw new IllegalArgumentException( + String.format( + "Object model factory %s clashes with %s. Both serve %s", + formatModel.getClass(), FORMAT_MODELS.get(key), key)); + } + + FORMAT_MODELS.put(key, formatModel); + } + + @SuppressWarnings("CatchBlockLogException") + private static void registerSupportedFormats() { + // Uses dynamic methods to call the `register` for the listed classes + for (String classToRegister : CLASSES_TO_REGISTER) { + try { + DynMethods.builder("register").impl(classToRegister).buildStaticChecked().invoke(); + } catch (NoSuchMethodException e) { + // failing to register a factory is normal and does not require a stack trace + LOG.info("Unable to register {} for data files: {}", classToRegister, e.getMessage()); + } + } + } + + static { + registerSupportedFormats(); + } + + private FormatModelRegistry() {} + + /** + * Returns a reader builder for the specified file format and object model. + * + * <p>The returned {@link ReadBuilder} provides a fluent interface for configuring how data is + * read from the input file and converted to the output objects. The builder supports + * configuration options like schema projection, predicate pushdown, batch size and encryption. + * + * @param format the file format (Parquet, Avro, ORC) that determines the parsing implementation + * @param modelName identifier for the expected output data representation (generic, spark, flink, + * etc.) + * @param inputFile source file to read data from + * @param <D> the type of data records the reader will produce + * @return a configured reader builder for the specified format and object model + */ + public static <D> ReadBuilder<?, D> readBuilder( + FileFormat format, String modelName, InputFile inputFile) { + FormatModel<D> factory = factoryFor(format, modelName); + return factory.readBuilder(inputFile); + } + + /** + * Returns a writer builder for appending data to the specified output file. + * + * <p>The returned builder produces a {@link FileAppender} that accepts records defined by the + * specified object model and persists them using the given file format. Data is written to the + * output file, but this basic writer does not collect or return {@link ContentFile} metadata. + * + * @param format the file format used for writing + * @param modelName name of the object model defining the input format + * @param outputFile destination for the written data + * @param <D> the type of data records the writer will accept + * @return a configured writer builder for creating the appender + */ + public static <D> WriteBuilder<?, D> writeBuilder( + FileFormat format, String modelName, EncryptedOutputFile outputFile) { + FormatModel<D> factory = factoryFor(format, modelName); + return factory.dataBuilder(outputFile.encryptingOutputFile()); + } + + /** + * Returns a writer builder for generating a {@link DataFile}. + * + * <p>The returned builder produces a writer that accepts records defined by the specified object + * model and persists them using the provided file format. Unlike basic writers, this writer + * collects file metadata during the writing process and generates a {@link DataFile} that can be + * used for table operations. + * + * @param format the file format used for writing + * @param modelName name of the object model defining the input format + * @param outputFile destination for the written data + * @param <D> the type of data records the writer will accept + * @return a configured data write builder for creating a {@link DataWriter} + */ + public static <D> DataWriteBuilder<?, D> dataWriteBuilder( + FileFormat format, String modelName, EncryptedOutputFile outputFile) { + FormatModel<D> factory = factoryFor(format, modelName); + WriteBuilder<?, D> writeBuilder = + factory.equalityDeleteBuilder(outputFile.encryptingOutputFile()); + return ContentFileWriteBuilderImpl.forDataFile( + writeBuilder, outputFile.encryptingOutputFile().location(), format); Review Comment: This is solved now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
