nastra commented on code in PR #14367:
URL: https://github.com/apache/iceberg/pull/14367#discussion_r2444960680
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -904,9 +904,7 @@ public void testTableSnapshotLoading() {
RESTCatalogProperties.SNAPSHOT_LOADING_MODE,
SnapshotMode.REFS.name()));
- if (requiresNamespaceCreate()) {
- catalog.createNamespace(TABLE.namespace());
- }
+ catalog.createNamespace(TABLE.namespace());
Review Comment:
`requiresNamespaceCreate()` depends on the backing catalog that is used in
testing. I'm ok removing the check but I think one reason that might justify
leaving the check in is when there are subclasses of `TestRESTCatalog` that
have `requiresNamespaceCreate()` return `false` and allow creating implicit
namespaces when the table is first created.
Let's see what others think here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
