slfan1989 commented on code in PR #14243:
URL: https://github.com/apache/iceberg/pull/14243#discussion_r2445087805
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ZkLockFactory.java:
##########
@@ -98,7 +100,7 @@ public ZkLockFactory(
this.connectionTimeoutMs = connectionTimeoutMs;
this.baseSleepTimeMs = baseSleepTimeMs;
this.maxRetries = maxRetries;
- this.retryPolicyName = retryPolicyName;
+ this.retryPolicy = retryPolicy;
Review Comment:
Yes, exactly — this is mainly due to serialization.
Curator’s `RetryPolicy` isn’t serializable,
so we only store the config values and recreate the `RetryPolicy` when
needed (e.g., after deserialization).
This avoids Flink serialization issues while keeping the behavior consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
