Fokko commented on code in PR #2560:
URL: https://github.com/apache/iceberg-python/pull/2560#discussion_r2445952163
##########
pyiceberg/expressions/__init__.py:
##########
@@ -247,9 +249,10 @@ def as_bound(self) -> Type[BoundReference[L]]:
return BoundReference[L]
-class And(BooleanExpression):
+class And(BooleanExpression, IcebergBaseModel):
Review Comment:
I think Pydantic requires the BaseModel to be the first class to be
inherited.
```suggestion
class And(IcebergBaseModel, BooleanExpression):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
