huaxingao commented on code in PR #14297:
URL: https://github.com/apache/iceberg/pull/14297#discussion_r2446808670
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -134,6 +134,30 @@ private void ensureWriterInitialized() {
@Override
public void add(T value) {
+ if (model instanceof WriterLazyInitializable) {
+ WriterLazyInitializable lazy = (WriterLazyInitializable) model;
+ if (lazy.needsInitialization()) {
+ model.write(0, value);
+ recordCount += 1;
+
+ if (!lazy.needsInitialization()) {
+ WriterLazyInitializable.InitializationResult result =
+ lazy.initialize(props, compressor, rowGroupOrdinal);
+ this.parquetSchema = result.getSchema();
+ this.pageStore = result.getPageStore();
+ this.writeStore = result.getWriteStore();
Review Comment:
Seems the initial `writeStore`/`pageStore` from `startRowGroup()` aren’t
closed before being replaced here. Could this cause memory leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
