pvary commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2447672631
##########
data/src/test/java/org/apache/iceberg/io/TestTaskEqualityDeltaWriter.java:
##########
@@ -74,12 +78,16 @@ public class TestTaskEqualityDeltaWriter extends TestBase {
@Parameter(index = 1)
protected FileFormat format;
- @Parameters(name = "formatVersion = {0}, FileFormat = {0}")
- protected static List<Object> parameters() {
- return Arrays.asList(
- new Object[] {FORMAT_V2, FileFormat.AVRO},
- new Object[] {FORMAT_V2, FileFormat.ORC},
- new Object[] {FORMAT_V2, FileFormat.PARQUET});
+ @Parameters(name = "formatVersion = {0}, FileFormat = {1}")
+ protected static List<Object[]> parameters() {
+ List<Object[]> parameters = Lists.newArrayList();
+ for (FileFormat format :
+ new FileFormat[] {FileFormat.AVRO, FileFormat.ORC,
FileFormat.PARQUET}) {
+ for (int version : TestHelpers.V2_AND_ABOVE) {
+ parameters.add(new Object[] {version, format});
+ }
+ }
+ return parameters;
Review Comment:
nit: newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
