Fokko commented on code in PR #2598:
URL: https://github.com/apache/iceberg-python/pull/2598#discussion_r2449291252
##########
tests/expressions/test_expressions.py:
##########
@@ -780,6 +780,16 @@ def test_not_null() -> None:
assert non_null == pickle.loads(pickle.dumps(non_null))
+def test_serialize_is_null() -> None:
+ pred = IsNull(term="foo")
+ assert pred.model_dump_json() == '{"type":"is-null","term":"foo"}'
+
+
+def test_serialize_not_null() -> None:
+ pred = NotNull(term="foo")
+ assert pred.model_dump_json() == '{"type":"not-null","term":"foo"}'
Review Comment:
```suggestion
def test_serialize_is_null() -> None:
pred = IsNull(term="foo")
assert pred.model_dump_json() == '{"term":"foo","type":"is-null"}'
def test_serialize_not_null() -> None:
pred = NotNull(term="foo")
assert pred.model_dump_json() == '{"term":"foo","type":"not-null"}'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
