jaimeferj opened a new pull request, #2652:
URL: https://github.com/apache/iceberg-python/pull/2652
Closes https://github.com/apache/iceberg-python/issues/2373
# Rationale for this change
This PR adds client version and git commit tracking headers to match the
Java Iceberg client implementation. The Java client sends
`X-Client-Version` and `X-Client-Git-Commit-Short` headers with all REST
catalog requests for better client tracking and debugging.
This implementation:
- Uses `setuptools_scm` to capture git version information at build time
- Extracts the short git commit hash from the version string
- Sends both headers with all REST catalog HTTP requests
This provides better visibility into which PyIceberg versions and builds
are making requests to REST catalogs, helping with
debugging and client tracking.
## Are these changes tested?
Yes
- Added `test_client_version_headers` to verify both headers are set
correctly
- Test validates that `X-Client-Version` matches the package version
- Test validates that `X-Client-Git-Commit-Short` is a valid 7-character
hex git hash
- All existing tests continue to pass
## Are there any user-facing changes?
Yes, but minimal:
- REST catalog HTTP requests now include two additional headers:
`X-Client-Version` and `X-Client-Git-Commit-Short`
- This is transparent to users and doesn't affect the API or behavior
- Server-side operators may see these new headers in their logs for better
client tracking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
