wgtmac commented on code in PR #251:
URL: https://github.com/apache/iceberg-cpp/pull/251#discussion_r2450175715
##########
src/iceberg/catalog/rest/CMakeLists.txt:
##########
@@ -15,25 +15,35 @@
# specific language governing permissions and limitations
# under the License.
-set(ICEBERG_REST_SOURCES rest_catalog.cc)
+set(ICEBERG_REST_SOURCES rest_catalog.cc json_internal.cc)
set(ICEBERG_REST_STATIC_BUILD_INTERFACE_LIBS)
set(ICEBERG_REST_SHARED_BUILD_INTERFACE_LIBS)
set(ICEBERG_REST_STATIC_INSTALL_INTERFACE_LIBS)
set(ICEBERG_REST_SHARED_INSTALL_INTERFACE_LIBS)
-list(APPEND ICEBERG_REST_STATIC_BUILD_INTERFACE_LIBS
- "$<IF:$<TARGET_EXISTS:iceberg_static>,iceberg_static,iceberg_shared>"
cpr::cpr)
-list(APPEND ICEBERG_REST_SHARED_BUILD_INTERFACE_LIBS
- "$<IF:$<TARGET_EXISTS:iceberg_shared>,iceberg_shared,iceberg_static>"
cpr::cpr)
+list(APPEND
+ ICEBERG_REST_STATIC_BUILD_INTERFACE_LIBS
+ "$<IF:$<TARGET_EXISTS:iceberg_static>,iceberg_static,iceberg_shared>"
+ cpr::cpr
+ nlohmann_json::nlohmann_json)
+list(APPEND
+ ICEBERG_REST_SHARED_BUILD_INTERFACE_LIBS
+ "$<IF:$<TARGET_EXISTS:iceberg_shared>,iceberg_shared,iceberg_static>"
+ cpr::cpr
+ nlohmann_json::nlohmann_json)
Review Comment:
```suggestion
list(APPEND
ICEBERG_REST_STATIC_BUILD_INTERFACE_LIBS
"$<IF:$<TARGET_EXISTS:iceberg_static>,iceberg_static,iceberg_shared>"
cpr::cpr)
list(APPEND
ICEBERG_REST_SHARED_BUILD_INTERFACE_LIBS
"$<IF:$<TARGET_EXISTS:iceberg_shared>,iceberg_shared,iceberg_static>"
cpr::cpr)
```
We don't need `nlohmann_json::nlohmann_json` explicitly because it is
already a `BUILD_INTERFACE` of the `iceberg` library. Could you double check?
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
+ std::vector<std::vector<std::string>> namespaces;
+ // TODO(Li Feiyang): Add next_page_token
+};
+
+struct CreateNamespaceRequest {
+ std::vector<std::string> namespaces;
+ std::optional<std::unordered_map<std::string, std::string>> properties;
Review Comment:
```suggestion
std::unordered_map<std::string, std::string> properties;
```
We don't need an extra `std::optional` here because an empty map can be
considered empty.
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
+ std::vector<std::vector<std::string>> namespaces;
Review Comment:
```suggestion
std::vector<Namespace> namespaces;
```
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
+ std::vector<std::vector<std::string>> namespaces;
+ // TODO(Li Feiyang): Add next_page_token
+};
+
+struct CreateNamespaceRequest {
Review Comment:
I'd suggest to add a file like
[iceberg_rest_api_todo.md](https://github.com/user-attachments/files/23044946/iceberg_rest_api_todo.md)
to the `rest` directory to keep track of the progress.
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
+ std::vector<std::vector<std::string>> namespaces;
+ // TODO(Li Feiyang): Add next_page_token
+};
+
+struct CreateNamespaceRequest {
Review Comment:
For each class, please add some docstring. We can simply copy the
description from the rest api spec.
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
Review Comment:
```suggestion
struct ICEBERG_REST_EXPORT ListNamespaceResponse {
```
##########
src/iceberg/catalog/rest/CMakeLists.txt:
##########
@@ -15,25 +15,35 @@
# specific language governing permissions and limitations
# under the License.
-set(ICEBERG_REST_SOURCES rest_catalog.cc)
+set(ICEBERG_REST_SOURCES rest_catalog.cc json_internal.cc)
set(ICEBERG_REST_STATIC_BUILD_INTERFACE_LIBS)
set(ICEBERG_REST_SHARED_BUILD_INTERFACE_LIBS)
set(ICEBERG_REST_STATIC_INSTALL_INTERFACE_LIBS)
set(ICEBERG_REST_SHARED_INSTALL_INTERFACE_LIBS)
-list(APPEND ICEBERG_REST_STATIC_BUILD_INTERFACE_LIBS
- "$<IF:$<TARGET_EXISTS:iceberg_static>,iceberg_static,iceberg_shared>"
cpr::cpr)
-list(APPEND ICEBERG_REST_SHARED_BUILD_INTERFACE_LIBS
- "$<IF:$<TARGET_EXISTS:iceberg_shared>,iceberg_shared,iceberg_static>"
cpr::cpr)
+list(APPEND
+ ICEBERG_REST_STATIC_BUILD_INTERFACE_LIBS
+ "$<IF:$<TARGET_EXISTS:iceberg_static>,iceberg_static,iceberg_shared>"
+ cpr::cpr
+ nlohmann_json::nlohmann_json)
+list(APPEND
+ ICEBERG_REST_SHARED_BUILD_INTERFACE_LIBS
+ "$<IF:$<TARGET_EXISTS:iceberg_shared>,iceberg_shared,iceberg_static>"
+ cpr::cpr
+ nlohmann_json::nlohmann_json)
list(APPEND
ICEBERG_REST_STATIC_INSTALL_INTERFACE_LIBS
"$<IF:$<TARGET_EXISTS:iceberg::iceberg_static>,iceberg::iceberg_static,iceberg::iceberg_shared>"
- "$<IF:$<BOOL:${CPR_VENDORED}>,iceberg::cpr,cpr::cpr>")
+ "$<IF:$<BOOL:${CPR_VENDORED}>,iceberg::cpr,cpr::cpr>"
Review Comment:
Same for here and below.
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
Review Comment:
We need to include `iceberg/catalog/rest/iceberg_rest_export.h` and add
`ICEBERG_REST_EXPORT` to all classes to export them in the shared library.
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
Review Comment:
Try to include `iceberg/type_fwd.h` (and remove some other header files
below) to use forward declaration as much as possible. The main point is to
make the compiler run faster.
Perhaps we can also add `iceberg/catalog/rest/type_fwd.h` to make it easy to
use forward declaration of the rest catalog library. It can be a separate PR
later.
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
+ std::vector<std::vector<std::string>> namespaces;
+ // TODO(Li Feiyang): Add next_page_token
+};
+
+struct CreateNamespaceRequest {
+ std::vector<std::string> namespaces;
+ std::optional<std::unordered_map<std::string, std::string>> properties;
+};
+
+struct CreateNamespaceResponse {
+ std::vector<std::string> namespaces;
+ std::optional<std::unordered_map<std::string, std::string>> properties;
+};
+
+struct GetNamespacePropertiesResponse {
+ std::vector<std::string> namespaces;
+ std::optional<std::unordered_map<std::string, std::string>> properties;
+};
+
+struct UpdateNamespacePropertiesRequest {
+ std::optional<std::vector<std::string>> removals;
+ std::optional<std::unordered_map<std::string, std::string>> updates;
+};
+
+struct UpdateNamespacePropsResponse {
+ std::vector<std::string> updated;
+ std::vector<std::string> removed;
+ std::optional<std::vector<std::string>> missing;
+};
+
+struct ListTableResponse {
+ std::optional<std::vector<TableIdentifier>> identifiers;
+ // TODO(Li Feiyang): Add next_page_token
+};
+
+struct CreateTableRequest {
+ std::string name;
+ std::optional<std::string> location;
+ std::shared_ptr<Schema> schema;
+ std::shared_ptr<PartitionSpec> partition_spec; // optional
Review Comment:
Instead of adding `// optional` comment, can we add `// required` to those
required fields?
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
+ std::vector<std::vector<std::string>> namespaces;
+ // TODO(Li Feiyang): Add next_page_token
+};
+
+struct CreateNamespaceRequest {
+ std::vector<std::string> namespaces;
+ std::optional<std::unordered_map<std::string, std::string>> properties;
+};
+
+struct CreateNamespaceResponse {
+ std::vector<std::string> namespaces;
+ std::optional<std::unordered_map<std::string, std::string>> properties;
+};
+
+struct GetNamespacePropertiesResponse {
+ std::vector<std::string> namespaces;
+ std::optional<std::unordered_map<std::string, std::string>> properties;
+};
+
+struct UpdateNamespacePropertiesRequest {
+ std::optional<std::vector<std::string>> removals;
+ std::optional<std::unordered_map<std::string, std::string>> updates;
+};
+
+struct UpdateNamespacePropsResponse {
+ std::vector<std::string> updated;
+ std::vector<std::string> removed;
+ std::optional<std::vector<std::string>> missing;
+};
+
+struct ListTableResponse {
+ std::optional<std::vector<TableIdentifier>> identifiers;
+ // TODO(Li Feiyang): Add next_page_token
+};
+
+struct CreateTableRequest {
+ std::string name;
+ std::optional<std::string> location;
Review Comment:
```suggestion
std::string location;
```
An empty string is enough to represent an optional one.
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
+ std::vector<std::vector<std::string>> namespaces;
+ // TODO(Li Feiyang): Add next_page_token
+};
+
+struct CreateNamespaceRequest {
+ std::vector<std::string> namespaces;
+ std::optional<std::unordered_map<std::string, std::string>> properties;
Review Comment:
Same for below
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
+ std::vector<std::vector<std::string>> namespaces;
Review Comment:
Let's reuse defined classes as many as possible.
##########
src/iceberg/catalog/rest/types.h:
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+#include "iceberg/partition_spec.h"
+#include "iceberg/schema.h"
+#include "iceberg/sort_order.h"
+#include "iceberg/table_identifier.h"
+#include "iceberg/table_metadata.h"
+
+namespace iceberg::rest {
+
+struct ListNamespaceResponse {
Review Comment:
BTW, this should be `ListNamespacesResponse` to be consistent with the rest
spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
