anuragmantri commented on code in PR #14161:
URL: https://github.com/apache/iceberg/pull/14161#discussion_r2453314178
##########
aws/src/main/java/org/apache/iceberg/aws/s3/PrefixedS3Client.java:
##########
@@ -35,6 +36,8 @@ class PrefixedS3Client implements AutoCloseable {
private SerializableSupplier<S3AsyncClient> s3Async;
private transient volatile S3Client s3Client;
private transient volatile S3AsyncClient s3AsyncClient;
+ private transient String httpClientKey;
Review Comment:
Makes sense to me. In the new revision, I introduced a
`WrappedSdkHttpClient` to wrap the `SdkHttpClient` object and delegate the
`close()` call to the registery. Now all the ref counting logic resides within
the registery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
