wgtmac commented on code in PR #272: URL: https://github.com/apache/iceberg-cpp/pull/272#discussion_r2453957627
########## src/iceberg/catalog/rest/request_types.h: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/partition_spec.h" +#include "iceberg/schema.h" +#include "iceberg/sort_order.h" +#include "iceberg/table_identifier.h" + +/// \file iceberg/catalog/rest/request_types.h +/// Defines all request body structures for the Iceberg REST Catalog API, +/// corresponding to the JSON payloads sent to various /v1 endpoints. + +namespace iceberg::rest { + +/// \brief Request to create a namespace. +/// \details Corresponds to **POST /v1/{prefix}/namespaces**. +/// Allows creating a new namespace with optional properties. Review Comment: ```suggestion /// \brief Request to create a namespace. ``` Let's keep the `brief` comment. ########## src/iceberg/catalog/rest/request_types.h: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/partition_spec.h" +#include "iceberg/schema.h" +#include "iceberg/sort_order.h" +#include "iceberg/table_identifier.h" + +/// \file iceberg/catalog/rest/request_types.h Review Comment: What is the rationale of splitting them into two files? What about just putting them together in `iceberg/catalog/rest/types.h`? ########## src/iceberg/catalog/rest/request_types.h: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/partition_spec.h" +#include "iceberg/schema.h" +#include "iceberg/sort_order.h" +#include "iceberg/table_identifier.h" + +/// \file iceberg/catalog/rest/request_types.h +/// Defines all request body structures for the Iceberg REST Catalog API, +/// corresponding to the JSON payloads sent to various /v1 endpoints. + +namespace iceberg::rest { + +/// \brief Request to create a namespace. +/// \details Corresponds to **POST /v1/{prefix}/namespaces**. +/// Allows creating a new namespace with optional properties. +struct ICEBERG_REST_EXPORT CreateNamespaceRequest { + Namespace namespace_; // required + std::unordered_map<std::string, std::string> properties; +}; + +/// \brief Request to update or remove namespace properties. +/// \details Corresponds to **POST /v1/{prefix}/namespaces/{namespace}/properties**. +/// Allows setting and/or removing namespace properties in a single call. +/// Properties not listed in this request are left unchanged. +struct ICEBERG_REST_EXPORT UpdateNamespaceRequest { Review Comment: ```suggestion struct ICEBERG_REST_EXPORT UpdateNamespacePropertiesRequest { ``` The name should be consistent with the rest spec. ########## src/iceberg/catalog/rest/response_types.h: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/table_identifier.h" +#include "iceberg/table_metadata.h" + +/// \file iceberg/catalog/rest/response_types.h +/// Defines all response body structures for the Iceberg REST Catalog API, +/// representing the JSON results returned by /v1 endpoints (excluding HTTP headers like +/// ETag). + +namespace iceberg::rest { + +/// \brief An opaque token that allows clients to make use of pagination for list APIs. +using PageToken = std::string; + +/// \brief Result body for table create/load/register APIs. +/// \details Matches **components/schemas/LoadTableResult** in the REST spec. +struct ICEBERG_REST_EXPORT LoadTableResult { + std::optional<std::string> metadata_location; + TableMetadata metadata; // required + std::unordered_map<std::string, std::string> config; + // TODO(Li Feiyang): Add std::vector<StorageCredential> storage_credentials; +}; + +/// \brief Alias of LoadTableResult used as the body of CreateTableResponse +using CreateTableResponse = LoadTableResult; + +/// \brief Alias of LoadTableResult used as the body of LoadTableResponse +using LoadTableResponse = LoadTableResult; + +/// \brief Alias of LoadTableResult used as the body of RegisterTableResponse +using RegisterTableResponse = LoadTableResult; + +/// \brief Response body for listing namespaces. +/// Contains all namespaces and an optional pagination token. +struct ICEBERG_REST_EXPORT ListNamespacesResponse { + std::optional<PageToken> next_page_token; Review Comment: ```suggestion PageToken next_page_token; ``` ########## src/iceberg/catalog/rest/response_types.h: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/table_identifier.h" +#include "iceberg/table_metadata.h" + +/// \file iceberg/catalog/rest/response_types.h +/// Defines all response body structures for the Iceberg REST Catalog API, +/// representing the JSON results returned by /v1 endpoints (excluding HTTP headers like +/// ETag). + +namespace iceberg::rest { + +/// \brief An opaque token that allows clients to make use of pagination for list APIs. +using PageToken = std::string; + +/// \brief Result body for table create/load/register APIs. +/// \details Matches **components/schemas/LoadTableResult** in the REST spec. +struct ICEBERG_REST_EXPORT LoadTableResult { + std::optional<std::string> metadata_location; + TableMetadata metadata; // required + std::unordered_map<std::string, std::string> config; + // TODO(Li Feiyang): Add std::vector<StorageCredential> storage_credentials; +}; + +/// \brief Alias of LoadTableResult used as the body of CreateTableResponse +using CreateTableResponse = LoadTableResult; + +/// \brief Alias of LoadTableResult used as the body of LoadTableResponse +using LoadTableResponse = LoadTableResult; + +/// \brief Alias of LoadTableResult used as the body of RegisterTableResponse +using RegisterTableResponse = LoadTableResult; + +/// \brief Response body for listing namespaces. +/// Contains all namespaces and an optional pagination token. +struct ICEBERG_REST_EXPORT ListNamespacesResponse { + std::optional<PageToken> next_page_token; + std::vector<Namespace> namespaces; +}; + +/// \brief Response body after creating a namespace. +/// \details Contains the created namespace and its resolved properties. +struct ICEBERG_REST_EXPORT CreateNamespaceResponse { + Namespace namespace_; // required + std::unordered_map<std::string, std::string> properties; +}; + +/// \brief Response body for loading namespace properties. +/// \details Contains stored properties, may be null if unsupported by the server. +struct ICEBERG_REST_EXPORT GetNamespaceResponse { + Namespace namespace_; // required + std::unordered_map<std::string, std::string> properties; +}; + +/// \brief Response body after updating namespace properties. +/// \details Lists keys that were updated, removed, or missing. +struct ICEBERG_REST_EXPORT UpdateNamespacePropertiesResponse { + std::vector<std::string> updated; // required + std::vector<std::string> removed; // required + std::vector<std::string> missing; +}; + +/// \brief Response body for listing tables in a namespace. +/// \details Contains all table identifiers and an optional pagination token. +struct ICEBERG_REST_EXPORT ListTablesResponse { + std::optional<PageToken> next_page_token; Review Comment: ```suggestion PageToken next_page_token; ``` ########## src/iceberg/catalog/rest/response_types.h: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/table_identifier.h" +#include "iceberg/table_metadata.h" + +/// \file iceberg/catalog/rest/response_types.h +/// Defines all response body structures for the Iceberg REST Catalog API, +/// representing the JSON results returned by /v1 endpoints (excluding HTTP headers like +/// ETag). + +namespace iceberg::rest { + +/// \brief An opaque token that allows clients to make use of pagination for list APIs. +using PageToken = std::string; + +/// \brief Result body for table create/load/register APIs. +/// \details Matches **components/schemas/LoadTableResult** in the REST spec. +struct ICEBERG_REST_EXPORT LoadTableResult { + std::optional<std::string> metadata_location; + TableMetadata metadata; // required + std::unordered_map<std::string, std::string> config; + // TODO(Li Feiyang): Add std::vector<StorageCredential> storage_credentials; +}; + +/// \brief Alias of LoadTableResult used as the body of CreateTableResponse +using CreateTableResponse = LoadTableResult; + +/// \brief Alias of LoadTableResult used as the body of LoadTableResponse +using LoadTableResponse = LoadTableResult; + +/// \brief Alias of LoadTableResult used as the body of RegisterTableResponse +using RegisterTableResponse = LoadTableResult; Review Comment: ```suggestion ``` ########## src/iceberg/catalog/rest/response_types.h: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/table_identifier.h" +#include "iceberg/table_metadata.h" + +/// \file iceberg/catalog/rest/response_types.h +/// Defines all response body structures for the Iceberg REST Catalog API, +/// representing the JSON results returned by /v1 endpoints (excluding HTTP headers like +/// ETag). + +namespace iceberg::rest { + +/// \brief An opaque token that allows clients to make use of pagination for list APIs. +using PageToken = std::string; + +/// \brief Result body for table create/load/register APIs. +/// \details Matches **components/schemas/LoadTableResult** in the REST spec. +struct ICEBERG_REST_EXPORT LoadTableResult { + std::optional<std::string> metadata_location; + TableMetadata metadata; // required Review Comment: ```suggestion std::shared_ptr<TableMetadata> metadata; // required ``` We should use shared_ptr to make sure that the copy of `LoadTableResult` is cheap (i.e. shallow copy). ########## src/iceberg/catalog/rest/response_types.h: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/table_identifier.h" +#include "iceberg/table_metadata.h" Review Comment: Use forward declaration ########## src/iceberg/catalog/rest/request_types.h: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/partition_spec.h" +#include "iceberg/schema.h" +#include "iceberg/sort_order.h" +#include "iceberg/table_identifier.h" + +/// \file iceberg/catalog/rest/request_types.h +/// Defines all request body structures for the Iceberg REST Catalog API, +/// corresponding to the JSON payloads sent to various /v1 endpoints. + +namespace iceberg::rest { + +/// \brief Request to create a namespace. +/// \details Corresponds to **POST /v1/{prefix}/namespaces**. +/// Allows creating a new namespace with optional properties. +struct ICEBERG_REST_EXPORT CreateNamespaceRequest { + Namespace namespace_; // required + std::unordered_map<std::string, std::string> properties; +}; + +/// \brief Request to update or remove namespace properties. +/// \details Corresponds to **POST /v1/{prefix}/namespaces/{namespace}/properties**. +/// Allows setting and/or removing namespace properties in a single call. +/// Properties not listed in this request are left unchanged. +struct ICEBERG_REST_EXPORT UpdateNamespaceRequest { + std::vector<std::string> removals; + std::unordered_map<std::string, std::string> updates; +}; + +/// \brief Request to create a table. +/// \details Corresponds to **POST /v1/{prefix}/namespaces/{namespace}/tables**. +/// If `stage_create` is false, the table is created immediately. +/// If `stage_create` is true, metadata is prepared and returned without committing, +/// allowing a later transaction commit via the table commit endpoint. +struct ICEBERG_REST_EXPORT CreateTableRequest { + std::string name; // required + std::string location; + std::shared_ptr<Schema> schema; // required + std::shared_ptr<PartitionSpec> partition_spec; + std::shared_ptr<SortOrder> write_order; + std::optional<bool> stage_create; + std::unordered_map<std::string, std::string> properties; +}; + +/// \brief Request to register an existing table. +/// \details Corresponds to **POST /v1/{prefix}/namespaces/{namespace}/register**. +/// Registers an existing table using a given metadata file location. +struct ICEBERG_REST_EXPORT RegisterTableRequest { + std::string name; // required + std::string metadata_location; // required + std::optional<bool> overwrite; Review Comment: ```suggestion bool overwrite = false; ``` ########## src/iceberg/catalog/rest/response_types.h: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/table_identifier.h" +#include "iceberg/table_metadata.h" + +/// \file iceberg/catalog/rest/response_types.h +/// Defines all response body structures for the Iceberg REST Catalog API, +/// representing the JSON results returned by /v1 endpoints (excluding HTTP headers like +/// ETag). + +namespace iceberg::rest { + +/// \brief An opaque token that allows clients to make use of pagination for list APIs. +using PageToken = std::string; + +/// \brief Result body for table create/load/register APIs. +/// \details Matches **components/schemas/LoadTableResult** in the REST spec. +struct ICEBERG_REST_EXPORT LoadTableResult { + std::optional<std::string> metadata_location; + TableMetadata metadata; // required + std::unordered_map<std::string, std::string> config; + // TODO(Li Feiyang): Add std::vector<StorageCredential> storage_credentials; Review Comment: ```suggestion // TODO(Li Feiyang): Add std::shared_ptr<StorageCredential> storage_credential; ``` ########## src/iceberg/catalog/rest/request_types.h: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/partition_spec.h" +#include "iceberg/schema.h" +#include "iceberg/sort_order.h" +#include "iceberg/table_identifier.h" + +/// \file iceberg/catalog/rest/request_types.h Review Comment: BTW, new headers are not compiled because no source file has included them. At least, you need to add them to `src/iceberg/catalog/rest/meson.build` by extending the `install_headers` list. ########## src/iceberg/catalog/rest/response_types.h: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/table_identifier.h" +#include "iceberg/table_metadata.h" + +/// \file iceberg/catalog/rest/response_types.h +/// Defines all response body structures for the Iceberg REST Catalog API, +/// representing the JSON results returned by /v1 endpoints (excluding HTTP headers like +/// ETag). + +namespace iceberg::rest { + +/// \brief An opaque token that allows clients to make use of pagination for list APIs. +using PageToken = std::string; + +/// \brief Result body for table create/load/register APIs. +/// \details Matches **components/schemas/LoadTableResult** in the REST spec. +struct ICEBERG_REST_EXPORT LoadTableResult { + std::optional<std::string> metadata_location; + TableMetadata metadata; // required + std::unordered_map<std::string, std::string> config; + // TODO(Li Feiyang): Add std::vector<StorageCredential> storage_credentials; +}; + +/// \brief Alias of LoadTableResult used as the body of CreateTableResponse +using CreateTableResponse = LoadTableResult; + +/// \brief Alias of LoadTableResult used as the body of LoadTableResponse +using LoadTableResponse = LoadTableResult; + +/// \brief Alias of LoadTableResult used as the body of RegisterTableResponse +using RegisterTableResponse = LoadTableResult; Review Comment: We don't have this, do we? ########## src/iceberg/catalog/rest/request_types.h: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#pragma once + +#include <memory> +#include <optional> +#include <string> +#include <unordered_map> +#include <vector> + +#include "iceberg/catalog/rest/iceberg_rest_export.h" +#include "iceberg/partition_spec.h" +#include "iceberg/schema.h" +#include "iceberg/sort_order.h" +#include "iceberg/table_identifier.h" + +/// \file iceberg/catalog/rest/request_types.h +/// Defines all request body structures for the Iceberg REST Catalog API, +/// corresponding to the JSON payloads sent to various /v1 endpoints. + +namespace iceberg::rest { + +/// \brief Request to create a namespace. +/// \details Corresponds to **POST /v1/{prefix}/namespaces**. +/// Allows creating a new namespace with optional properties. Review Comment: Same for below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
