pvary commented on code in PR #14312:
URL: https://github.com/apache/iceberg/pull/14312#discussion_r2455011962
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -119,6 +110,11 @@ public void
commit(Collection<CommitRequest<DynamicCommittable>> commitRequests)
return;
}
+ /*
+ TODO: Replace List<CommitRequest<DynamicCommittable>> with a single
CommitRequest<DynamicCommittable>
Review Comment:
Is this because we still need to be prepared for the old state, where we
have a List of committables?
Could we add this to the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
