kevinjqliu commented on code in PR #14267: URL: https://github.com/apache/iceberg/pull/14267#discussion_r2462962833
########## site/dev/common.sh: ########## Review Comment: looks like we're still pulling all the versions; i see them in `site/docs/docs`. mkdocs seems to be still parsing through all the folders even though the reference is removed in `nav-dev.yml`. This is a one of the major issues with slow builds. In https://github.com/apache/iceberg/pull/14154/files#diff-c629cce095c9a6fc10c7c3eedb3f57970f6cd3600f767d5cf333e6493176a29fR23-R29, I had to explicitly remove them ########## site/dev/setup_env.sh: ########## @@ -27,3 +27,14 @@ install_deps pull_versioned_docs git show "${REMOTE}/main:../.asf.yaml" > docs/.asf.yaml + +# If running in dev mode, temporarily use the dev navigation file +if [ "${ICEBERG_DEV_MODE:-false}" = "true" ]; then + echo " --> Using dev navigation (nav-dev.yml) for faster builds" + # Create a backup of the original nav.yml + if [ ! -f nav.yml.backup ]; then + cp nav.yml nav.yml.backup + fi + # Use the dev nav file + cp nav-dev.yml nav.yml Review Comment: i see that `clean.sh` is suppose to put the backup back but it has to be called it explicitly after calling `make serve-dev` ########## site/dev/setup_env.sh: ########## @@ -27,3 +27,14 @@ install_deps pull_versioned_docs git show "${REMOTE}/main:../.asf.yaml" > docs/.asf.yaml + +# If running in dev mode, temporarily use the dev navigation file +if [ "${ICEBERG_DEV_MODE:-false}" = "true" ]; then + echo " --> Using dev navigation (nav-dev.yml) for faster builds" + # Create a backup of the original nav.yml + if [ ! -f nav.yml.backup ]; then + cp nav.yml nav.yml.backup + fi + # Use the dev nav file + cp nav-dev.yml nav.yml Review Comment: nit: i dont love the idea that we're overwriting `nav.yml`. Feels like theres a potential footgun here to check in the the `nav.yml` file after its been replaced by `nav-dev.yml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
