kevinjqliu commented on issue #2514:
URL: 
https://github.com/apache/iceberg-python/issues/2514#issuecomment-3448929930

   IMO, i would separate out secrets from pyiceberg's configs, and merge them 
when accessing the catalog, i.e. `load_catalog`.
   
   Like so. This gives the user the ability to implement their own logic for 
loading secrets. 
   ```
   secrets = load_my_secret()
   load_catalog(catalog_name, **{**catalog_configs, **secrets})
   ```
   
   For example, for [REST catalog 
authentication](https://py.iceberg.apache.org/configuration/#authentication-options),
 `load_my_secret` can fetch "OAuth2 Authentication" options from anywhere. As 
long as its in the right format, when calling `load_catalog`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to