vustef commented on code in PR #1791:
URL: https://github.com/apache/iceberg-rust/pull/1791#discussion_r2465614941
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -183,6 +186,14 @@ impl<'a> TableScanBuilder<'a> {
self
}
+ /// Sets the metadata columns to include in the result
+ ///
+ /// Metadata columns are virtual columns that provide metadata about the
rows,
+ /// such as file paths or row positions. These come from
https://iceberg.apache.org/spec/#identifier-field-ids
+ pub fn with_metadata_columns(mut self, metadata_columns: Vec<String>) ->
Self {
Review Comment:
Need some validation here, for allowed column names. Or type safety, to pick
columns from enum (possibly preventing duplication?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
