hamilton-earthscope commented on code in PR #612:
URL: https://github.com/apache/iceberg-go/pull/612#discussion_r2466323845
##########
catalog/internal/utils.go:
##########
@@ -31,40 +32,48 @@ import (
"github.com/apache/iceberg-go"
"github.com/apache/iceberg-go/catalog"
- "github.com/apache/iceberg-go/io"
+ icebergio "github.com/apache/iceberg-go/io"
"github.com/apache/iceberg-go/table"
"github.com/google/uuid"
)
-func GetMetadataLoc(location string, newVersion uint) string {
- return fmt.Sprintf("%s/metadata/%05d-%s.metadata.json",
- location, newVersion, uuid.New().String())
-}
Review Comment:
t was not.
i tried to use it but got a circular reference between `table/` and
`internal/` so i just removed the dead code instead.
##########
catalog/internal/utils.go:
##########
@@ -31,40 +32,48 @@ import (
"github.com/apache/iceberg-go"
"github.com/apache/iceberg-go/catalog"
- "github.com/apache/iceberg-go/io"
+ icebergio "github.com/apache/iceberg-go/io"
"github.com/apache/iceberg-go/table"
"github.com/google/uuid"
)
-func GetMetadataLoc(location string, newVersion uint) string {
- return fmt.Sprintf("%s/metadata/%05d-%s.metadata.json",
- location, newVersion, uuid.New().String())
-}
Review Comment:
it was not.
i tried to use it but got a circular reference between `table/` and
`internal/` so i just removed the dead code instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
