ebyhr commented on code in PR #14429:
URL: https://github.com/apache/iceberg/pull/14429#discussion_r2467602689
##########
api/src/test/java/org/apache/iceberg/TestSchema.java:
##########
@@ -120,6 +138,13 @@ public void testUnsupportedTypes(Type type, int
unsupportedVersion) {
MIN_FORMAT_VERSIONS.get(type.typeId()));
}
+ @Test
+ public void testDuplicateIDs() {
+ assertThatThrownBy(() ->
Schema.checkCompatibility(generateTypeSchemaDuplicateID(), 2))
Review Comment:
The exception happens in `generateTypeSchemaDuplicateID`, not in
`checkCompatibility`, right? This test seems a bit misleading since the outer
method is redundant.
Also, we already have `TestNameMapping#testFailsDuplicateId` to test
duplicate ID from `Schema` constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
