MaxNevermind commented on PR #14269:
URL: https://github.com/apache/iceberg/pull/14269#issuecomment-3454499631
@anuragmantri @singhpk234
Can you please look at it again?
The current state of tests coverage and some questions:
✅ Partition spec preservation - 2 tests for partitioned an not
partitioned tables
✅ IF NOT EXISTS behavior
✅ TBLPROPERTIES - a single test for merge and override
❓ Sort order preservation - Do we want to support Sort order
functionality in CREATE TABLE LIKE? I see that [Spark's
DDL](https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-create-table-like.html)
doesn't have it. In Iceberg DDL we also add ordering separately by using ALTER
TABLE.
❓ Cross-catalog table copying - Do we want this functionality? I might
be wrong but I don't see test for that in other DDL statements, does Iceberg
even support cross-catalog DDL?
❓ Error cases (source table doesn't exist, non-Iceberg source, etc.) -
I'm not sure what I'm supposed to test for that. Do I have to test that
exception will be thrown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
