mbutrovich commented on code in PR #1778:
URL: https://github.com/apache/iceberg-rust/pull/1778#discussion_r2469349968
##########
crates/iceberg/src/arrow/caching_delete_file_loader.rs:
##########
@@ -224,14 +224,12 @@ impl CachingDeleteFileLoader {
let (sender, receiver) = channel();
del_filter.insert_equality_delete(&task.file_path, receiver);
+ // Equality deletes intentionally have partial schemas. Schema
evolution would add
+ // NULL values for missing REQUIRED columns, causing Arrow
validation to fail.
Ok(DeleteFileContext::FreshEqDel {
- batch_stream: BasicDeleteFileLoader::evolve_schema(
- basic_delete_file_loader
- .parquet_to_batch_stream(&task.file_path)
- .await?,
- schema,
- )
- .await?,
+ batch_stream: basic_delete_file_loader
Review Comment:
Sounds good, thank you for the reference! I'm still learning my way around
the Iceberg spec so I appreciate the check. I am addressing your comments in
#1777 and it will result in a new schema being passed to `ArrowReaderOptions`
so let me get that sorted first, and then maybe I can adapt the changes here to
the modified schema being passed into `ArrowReaderOptions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
