kevinjqliu commented on code in PR #1796:
URL: https://github.com/apache/iceberg-rust/pull/1796#discussion_r2471218812
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -80,17 +80,28 @@ jobs:
- uses: actions/checkout@v5
- uses: actions/setup-python@v6
with:
- python-version: 3.9
+ python-version: 3.12
- uses: PyO3/maturin-action@v1
with:
working-directory: "bindings/python"
command: build
args: --out dist --sdist
+ - name: Install uv
+ shell: bash
+ run: |
+ python -m pip install uv==0.9.3
Review Comment:
```suggestion
- name: Install uv
uses: astral-sh/setup-uv@v6
with:
version: "0.9.3"
```
nit: recommend to use the setup-uv action,
https://docs.astral.sh/uv/guides/integration/github/#installation
##########
bindings/python/pyproject.toml:
##########
@@ -25,14 +25,13 @@ classifiers = [
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
- "Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
]
name = "pyiceberg-core"
readme = "project-description.md"
-requires-python = "~=3.9"
+requires-python = ">=3.10,<3.13"
Review Comment:
```suggestion
requires-python = ">=3.10"
```
nit: do we have to use upperbound?
##########
bindings/python/pyproject.toml:
##########
@@ -48,10 +47,11 @@ include = [
[tool.ruff.lint]
ignore = ["F403", "F405"]
-[tool.hatch.envs.dev]
-dependencies = ["maturin>=1.0,<2.0", "pytest>=8.3.2", "datafusion==50.*",
"pyiceberg[sql-sqlite,pyarrow]>=0.10.0", "fastavro>=1.11.1"]
-
-[tool.hatch.envs.dev.scripts]
-build = "maturin build --out dist --sdist"
-develop = "maturin develop"
-test = "pytest"
+[dependency-groups]
+dev = [
+ "maturin>=1.0,<2.0",
+ "pytest>=8.3.2",
+ "datafusion==50.*",
+ "pyiceberg[sql-sqlite,pyarrow] @
git+https://github.com/apache/iceberg-python.git@d3eb149fe99b14e714a06e727b69cd617c6c052d";,
Review Comment:
why are we using this specific commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
