singhpk234 commented on code in PR #14442:
URL: https://github.com/apache/iceberg/pull/14442#discussion_r2476124426
##########
api/src/main/java/org/apache/iceberg/exceptions/NoSuchPlanIdException.java:
##########
@@ -16,21 +16,23 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.iceberg.flink.maintenance.api;
+package org.apache.iceberg.exceptions;
-public enum ZKRetryPolicies {
- /** A retry policy that retries only once */
- ONE_TIME,
+import com.google.errorprone.annotations.FormatMethod;
- /** A retry policy that retries a max number of times */
- N_TIME,
-
- /** A retry policy that retries a set number of times with increasing sleep
time */
- EXPONENTIAL_BACKOFF,
+/**
+ * Exception thrown when attempting to fetch scan planning results for a plan
ID that does not
Review Comment:
```suggestion
* Exception raised when attempting to fetch scan planning results for a
plan ID that does not
```
##########
api/src/main/java/org/apache/iceberg/exceptions/NoSuchPlanIdException.java:
##########
@@ -16,21 +16,23 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.iceberg.flink.maintenance.api;
+package org.apache.iceberg.exceptions;
-public enum ZKRetryPolicies {
- /** A retry policy that retries only once */
- ONE_TIME,
+import com.google.errorprone.annotations.FormatMethod;
- /** A retry policy that retries a max number of times */
- N_TIME,
-
- /** A retry policy that retries a set number of times with increasing sleep
time */
- EXPONENTIAL_BACKOFF,
+/**
+ * Exception thrown when attempting to fetch scan planning results for a plan
ID that does not
+ * exist.
+ */
+public class NoSuchPlanIdException extends RESTException {
Review Comment:
LG :
https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L4819
##########
api/src/main/java/org/apache/iceberg/exceptions/NoSuchPlanTaskException.java:
##########
@@ -16,21 +16,19 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.iceberg.flink.maintenance.api;
+package org.apache.iceberg.exceptions;
-public enum ZKRetryPolicies {
- /** A retry policy that retries only once */
- ONE_TIME,
+import com.google.errorprone.annotations.FormatMethod;
- /** A retry policy that retries a max number of times */
- N_TIME,
+/** Exception thrown when attempting to fetch result tasks for a plan task
that does not exist. */
+public class NoSuchPlanTaskException extends RESTException {
Review Comment:
Looks Good :
https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
