Kontinuation commented on code in PR #12667: URL: https://github.com/apache/iceberg/pull/12667#discussion_r2476867544
########## api/src/main/java/org/apache/iceberg/geospatial/BoundingBox.java: ########## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.geospatial; + +import java.nio.ByteBuffer; +import java.nio.ByteOrder; +import java.util.Objects; + +/** + * Represents a geospatial bounding box composed of minimum and maximum bounds. + * + * <p>A bounding box (also called a Minimum Bounding Rectangle or MBR) is defined by two points: the + * minimum and maximum coordinates that define the box's corners. This provides a simple + * approximation of a more complex geometry for efficient filtering and data skipping. + */ +public class BoundingBox { + /** + * Create a {@link BoundingBox} object from buffers containing min and max bounds + * + * @param min the serialized minimum bound + * @param max the serialized maximum bound + * @return a BoundingBox instance + */ + public static BoundingBox fromByteBuffers(ByteBuffer min, ByteBuffer max) { Review Comment: I have thought about this. We have a [BoundingBoxLiteral](https://github.com/apache/iceberg/pull/14101/files#diff-61c8d1a2f23df048a6498a256e15f920799df6bf2a26fdd583adef529e460f7eR726-R732) that constructs using a BoundingBox value. There are other helper static functions defined in [Expressions.java](https://github.com/apache/iceberg/pull/14101/files#diff-b07827b9bce988e458eb2170f4a9e526d732256e1e9a98661d7fc7fd856229aeR207-R224) for constructing spatial predicates using BoundingBox objects. The byte buffer serialization won't introduce too much friction to the users of this API. The `BoundingBoxLiteral` extends `BaseLiteral<ByteBuffer>` but not `BaseLiteral<BoundingBox>`. This is for compatibility with the current design of [`UnboundPredicate`](https://github.com/apache/iceberg/blob/92ae3d9da2afba3fa6fa0f74af6d78d773a6ab26/api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java) and [`BoundLiteralPredicate`](https://github.com/apache/iceberg/blob/92ae3d9da2afba3fa6fa0f74af6d78d773a6ab26/api/src/main/java/org/apache/iceberg/expressions/BoundPredicate.java). `UnboundPredicate<T>` holds a term `UnboundTerm<T>` and a list of literals `List<Literal<T>>`. The underlying types of term and literal should be the same. `BoundLiteralPredicate<T>` has similar requirement, it holds a term `BoundTerm<T>` and a literal `Literal<T>`. The underlying java type of [geometry and geography types](https://github.com/apache/iceberg/blob/92ae3d9da2afba3fa6fa0f74af6d78d773a6ab26/api/src/main/java/org/apache/iceberg/types/Type.java#L47-L48) are all `ByteBuffer`. A spatial predicate involving geospatial term should be represented by `UnboundPredicate<ByteBuffer>` and `BoundLiteralPredicate<ByteBuffer>` in the current design. This implies that the literal type should be `Literal<ByteBuffer>` as well. I made [an initial attempt](https://github.com/Kontinuation/iceberg/blob/full-pr-geo-bounds/api/src/main/java/org/apache/iceberg/expressions/BoundGeospatialPredicate.java) that defines `BoundGeospatialPredicate` that works with `BoundTerm<ByteBuffer>` and `Literal<BoundingBox>`, but I decided to switch to something based on the current approach for simplicity. I'm OK with either approach, I'll update the PR once we have concensus on the API design of spatial predicates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
