mbutrovich commented on code in PR #1802:
URL: https://github.com/apache/iceberg-rust/pull/1802#discussion_r2478949775
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -22,10 +22,12 @@ use std::cmp::Ordering;
use std::collections::HashMap;
use std::fmt::{Display, Formatter};
use std::hash::Hash;
+use std::io::Read as _;
use std::sync::Arc;
use _serde::TableMetadataEnum;
use chrono::{DateTime, Utc};
+use flate2::read::GzDecoder;
Review Comment:
When you go to read `metadata_content` it's already in memory as a `&[u8]`
so I think we should use `flate2::bufread::GzDecoder` here. It might be an
imperceptible performance difference, but you never know how big metadata might
get :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
