huaxingao commented on code in PR #14349:
URL: https://github.com/apache/iceberg/pull/14349#discussion_r2479078090
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkVariantRead.java:
##########
@@ -169,4 +169,112 @@ public void testVariantNullValueProjection(boolean
vectorized) {
assertThat(row.getLong(0)).isEqualTo(10L);
assertThat(row.isNullAt(1)).isTrue();
}
+
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
+ public void testNestedStructVariant(boolean vectorized) {
+ assumeThat(vectorized).as("Variant vectorized Parquet read is not
implemented yet").isFalse();
+ spark.conf().set("spark.sql.parquet.enableVectorizedReader",
String.valueOf(vectorized));
Review Comment:
I just noticed that some of the tests in this test set vectorization via
table property. To be consistent, I will change all the tests to use table
property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
