nastra commented on PR #14456: URL: https://github.com/apache/iceberg/pull/14456#issuecomment-3473777016
> This patch LGTM, though I have doubt on detecting namespace empty in case of `nested-namespace` > > lets say i have a structure like this > > ``` > NS1 > / \ \ > T V NS2 > / \ > T V > ``` > > T is Table, V is view NS1 and NS2 a namespace we want to drop NS1 shouldn't in addition to this we check GET /namespaces?parent=NS1 This is probably a good candidate to tackle in a separate PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
