pvary commented on code in PR #14435:
URL: https://github.com/apache/iceberg/pull/14435#discussion_r2486782518


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -167,6 +167,16 @@ private TableProperties() {}
       "write.parquet.bloom-filter-max-bytes";
   public static final int PARQUET_BLOOM_FILTER_MAX_BYTES_DEFAULT = 1024 * 1024;
 
+  /**
+   * Controls whether to use ParquetFileMerger for row-group level merging 
during compaction. When
+   * enabled, Parquet files are merged at the row-group level without full 
deserialization,
+   * providing significant performance improvements (up to 13x faster) 
compared to traditional
+   * read-rewrite approaches.
+   */
+  public static final String PARQUET_USE_FILE_MERGER = 
"write.parquet.use-file-merger";

Review Comment:
   Why is this a table property?
   Shouldn't this be a property for the rewrite?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to