kevinjqliu commented on issue #2684: URL: https://github.com/apache/iceberg-python/issues/2684#issuecomment-3482493550
Good catch and thanks for the repro. looks like we're not currently checking the nullability of the map itself, https://github.com/apache/iceberg-python/blob/5773b7f1bf2081a90a490f9d670eef804eb88ab4/pyiceberg/schema.py#L1800-L1808 And the Map key is always required https://github.com/apache/iceberg-python/blob/5773b7f1bf2081a90a490f9d670eef804eb88ab4/pyiceberg/types.py#L582 I think in java, we use the nullability of the Map value type to check whether the Map itself should be optional https://github.com/apache/iceberg/blob/3ccb29624283bbb70cb7c70abf6855a61c29d232/api/src/main/java/org/apache/iceberg/types/CheckCompatibility.java#L237-L239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
