RussellSpitzer commented on a change in pull request #1687:
URL: https://github.com/apache/iceberg/pull/1687#discussion_r514403724
##########
File path:
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
##########
@@ -144,27 +145,26 @@ protected String writeNewMetadata(TableMetadata metadata,
int newVersion) {
return newMetadataLocation.location();
}
- protected void refreshFromMetadataLocation(String newLocation) {
- refreshFromMetadataLocation(newLocation, null, 20);
+ protected boolean refreshFromMetadataLocation(String newLocation, String
previousLocation) {
+ return refreshFromMetadataLocation(newLocation, previousLocation, null,
20);
}
- protected void refreshFromMetadataLocation(String newLocation, int
numRetries) {
- refreshFromMetadataLocation(newLocation, null, numRetries);
+ protected boolean refreshFromMetadataLocation(String newLocation, String
previousLocation, int numRetries) {
+ return refreshFromMetadataLocation(newLocation, previousLocation, null,
numRetries);
}
- protected void refreshFromMetadataLocation(String newLocation,
Predicate<Exception> shouldRetry,
- int numRetries) {
+ protected boolean refreshFromMetadataLocation(
Review comment:
iceberg style is to put the new line only before the arguments that
don't fit within the line width. So
```
foo( x, y,
z)
```
Not
```
foo (x,
y,
z)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
