kbendick opened a new pull request #1692: URL: https://github.com/apache/iceberg/pull/1692
The labeler worked in my fork, but not when I pushed a change to this repo. On further inspection, it seems that the target of the workflow needs to be on `pull_request_target`, so that people who don't have push / write access to the repo can still trigger the workflow. I found this here: https://github.com/actions/labeler/issues/12 I also need to verify the permissions with ASF infra for `Fork Pull Request Workflows` to ensure that nobody can gain easy access to our secrets (I assume they likely have it set up correctly already, but since this is our first foray into the land of official github workflows, it's likely best to double check). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
