gbrgr commented on code in PR #1824:
URL: https://github.com/apache/iceberg-rust/pull/1824#discussion_r2490112802
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -280,6 +315,7 @@ impl<'a> TableScanBuilder<'a> {
partition_filter_cache: Arc::new(PartitionFilterCache::new()),
manifest_evaluator_cache: Arc::new(ManifestEvaluatorCache::new()),
expression_evaluator_cache:
Arc::new(ExpressionEvaluatorCache::new()),
+ file_column_position,
Review Comment:
I had the impression that storing it in field_ids, projected_field_ids, etc.
makes things sometimes harder, as before building the arrow batch builder one
needs to filter out those special fields. If one adds more than one such
special fields, the suggestion would be to maybe manage them in a hash map, but
keeping them separate makes sense I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
