aiborodin commented on code in PR #14503: URL: https://github.com/apache/iceberg/pull/14503#discussion_r2493134655
########## core/src/main/java/org/apache/iceberg/SupportsCommitValidation.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.function.BiConsumer; +import org.apache.iceberg.exceptions.CommitFailedException; + +public interface SupportsCommitValidation { + CommitValidator NON_VALIDATING = (base, metadata) -> {}; + + @FunctionalInterface + interface CommitValidator extends BiConsumer<TableMetadata, TableMetadata> { + @Override + void accept(TableMetadata base, TableMetadata current); Review Comment: Should this accept `Snapshot` as a parameter to avoid depending on `core` classes? Or match the existing validation signature in `SnapshotProducer`: ```java /** * Validate the current metadata. * * <p>Child operations can override this to add custom validation. * * @param currentMetadata current table metadata to validate * @param snapshot ending snapshot on the lineage which is being validated */ protected void validate(TableMetadata currentMetadata, Snapshot snapshot) {} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
