WillAyd commented on code in PR #292:
URL: https://github.com/apache/iceberg-cpp/pull/292#discussion_r2494326391
##########
src/iceberg/test/meson.build:
##########
@@ -96,6 +96,12 @@ if get_option('rest').enabled()
}
endif
+cpp = meson.get_compiler('cpp')
+cpp_bigobj_args = []
+if cpp.get_id() == 'msvc'
Review Comment:
Just some extra consideration points for youf:
1. The `if cpp.get_id() == 'msvc'` and `cpp.get_supported_arguments(...)`
calls are redundant; the latter is all you need. I don't think the redundancy
here is bad, but if you have a lot of arguments its usually easier to let Meson
figure out what is applicable, rather than branching on each compiler
2. Rather than applying this at the target level, you _might_ want to apply
/bigobj to all targets in the project. So in the root configuration something
like:
```python
args = cpp.get_supported_arguments(['/bigobj'])
add_project_arguments(args, language: 'cpp')
```
Would lessen redundancy as more targets require this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
