gaborkaszab commented on code in PR #14508:
URL: https://github.com/apache/iceberg/pull/14508#discussion_r2494398563
##########
core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java:
##########
@@ -349,7 +350,7 @@ private static Collection<PartitionStats>
computeAndMergeStatsIncremental(
Pair.of(key.first(), partitionDataToRecord((PartitionData)
key.second())),
value,
(existingEntry, newEntry) -> {
- existingEntry.appendStats(newEntry);
+ ((PartitionStats) existingEntry).appendStats(newEntry);
Review Comment:
If PartitionStatistics interface had the `appendStats` function, this cast
(and another occurrence) wouldn't be needed. It seemed a bit weird to have it
there, but I'm open to make this change to clean up casts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
