huaxingao commented on PR #14401: URL: https://github.com/apache/iceberg/pull/14401#issuecomment-3494570153
Thanks @jamespfaulkner for the PR! It looks good to me overall. Could we also add a test for a pre-epoch timestamp case (e.g., 1965-01-01 10:11:12.123) and a test that exercises the new writer code paths? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
