pvary commented on code in PR #14499:
URL: https://github.com/apache/iceberg/pull/14499#discussion_r2502377588
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -541,31 +541,41 @@ public Optional<LogicalTypeVisitorResult> visit(
@Override
public Optional<LogicalTypeVisitorResult> visit(
LogicalTypeAnnotation.TimestampLogicalTypeAnnotation
timestampLogicalType) {
- FieldVector vector = arrowField.createVector(rootAlloc);
switch (timestampLogicalType.getUnit()) {
case MILLIS:
- ((BigIntVector) vector).allocateNew(batchSize);
+ Field bigIntField =
+ new Field(
+ icebergField.name(),
+ new FieldType(
+ icebergField.isOptional(), new ArrowType.Int(Long.SIZE,
true), null, null),
+ null);
+ FieldVector millisVector = bigIntField.createVector(rootAlloc);
+ ((BigIntVector) millisVector).allocateNew(batchSize);
Review Comment:
> 1. All 64-bit fixed-width vectors in arrow share the same underlying
memory layout by design ([check
here](https://github.com/apache/iceberg/blob/bbf5b8a9060932931275160d262af314c5c1f336/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java#L474))
I think this link points to a different place what you originally intended.
I would love to see what you wanted to show me.
For the others, thanks a lot for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
