singhpk234 commented on code in PR #13400: URL: https://github.com/apache/iceberg/pull/13400#discussion_r2503520021
########## core/src/main/java/org/apache/iceberg/util/ParallelIterable.java: ########## @@ -52,6 +52,9 @@ public class ParallelIterable<T> extends CloseableGroup implements CloseableIter private final Iterable<? extends Iterable<T>> iterables; private final ExecutorService workerPool; + private final ConcurrentLinkedQueue<Iterable<T>> pendingIterables = new ConcurrentLinkedQueue<>(); Review Comment: I agree, though i haven't moved this into a seperate pr because we are still debating if we need : 1. Approach implemented in this PR 2. Approach @amogh-jahagirdar mentioned https://github.com/apache/iceberg/pull/13400#pullrequestreview-3341995863 3. Approach @danielcweeks suggested which i implemented here https://github.com/apache/iceberg/pull/14444 seems like we are now inclined towards 3, what are your thoughts considering all the 3 approaches ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
