ajreid21 commented on code in PR #14525:
URL: https://github.com/apache/iceberg/pull/14525#discussion_r2504438680
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -153,16 +154,15 @@ private void commit(boolean partialCommit) {
private void doCommit(boolean partialCommit) {
Map<TableReference, List<Envelope>> commitMap =
commitState.tableCommitMap();
-
- String offsetsJson = offsetsJson();
OffsetDateTime validThroughTs = commitState.validThroughTs(partialCommit);
Tasks.foreach(commitMap.entrySet())
.executeWith(exec)
.stopOnFailure()
.run(
entry -> {
- commitToTable(entry.getKey(), entry.getValue(), offsetsJson,
validThroughTs);
+ commitToTable(
+ entry.getKey(), entry.getValue(), controlTopicOffsets(),
validThroughTs);
});
// we should only get here if all tables committed successfully...
Review Comment:
@danielcweeks @bryanck Does the method below (committing the control topic
offsets) need to have the merged offsets as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
