rdblue commented on code in PR #14510:
URL: https://github.com/apache/iceberg/pull/14510#discussion_r2505791267
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -296,6 +301,28 @@ private void commitToTable(
}
}
+ private SnapshotAncestryValidator offsetValidator(
+ TableIdentifier tableIdentifier, Map<Integer, Long> expectedOffsets) {
+
+ return new SnapshotAncestryValidator() {
+ private Map<Integer, Long> lastCommittedOffsets;
+
+ @Override
+ public Boolean apply(Iterable<Snapshot> baseSnapshots) {
+ lastCommittedOffsets = lastCommittedOffsets(baseSnapshots);
+
+ return expectedOffsets.equals(lastCommittedOffsets);
+ }
+
+ @Override
+ public String errorMessage() {
+ return String.format(
+ "Latest offsets do not match expected offsets for this commit.
Table: %s, Expected: %s, Last Committed: %s",
Review Comment:
This is less important in connector code vs core, but I like to have more
direct error messages. For example, `"Cannot commit to %s, stale
offsets:\nExpected: %s\nCommitted: %s"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
